New Post: Together better

Hi Pavel,

There are a few problems I see in the ImapX code.

1. It doesn't appear to me that ImapX handles parsing of LIST responses that use literals for the mailbox name (unless the regex logic somehow handles it, but I didn't know where to look for the regex pattern).
   
2. In Folder.cs, in the AppendMessage() method, your code assumes that the email.Length is the same as the octet length, but they are not. The String.Length property is the unicode character count, not the octet count. You need to convert to a byte[] and then use that length.
   

If you decide to switch to using MimeKit.MimeMessages instead of strings in your API, you could do the following:

var options = MimeKit.FormatOptions.Default.Clone ();
options.NewLineFormat = MimeKit.NewLineFormat.Dos;

long octets;
using (var measure = new MimeKit.IO.MeasureStream ()) {
    message.WriteTo (options, measure);
    octets = measure.Length;
}

A measure stream is just there to measure the number of bytes written to it but doesn't actually store any data, so it's really useful for this sort of thing.

It's a bit worrisome is that I can't find where you handle literal strings in responses from the IMAP server. It seems to me that you use a StreamReader to read line-by-line, and simply assume that the text after the first line is the message body until you reach a line beginning with a ")". This, however, is incorrect for at least 2 reasons:

1. What if a line in the message begins with ")"? I have some LISP emails that have lines beginning with a ")" that your ImapX client library would likely break on if I tried to fetch them over an ImapXClient connection.
   
2. The message data itself isn't required to end with a CRLF which means that the last line of the literal may end mid-line which means that the ")" would also be mid-line and not at the beginning of a line like your code seems to depend on.
   

You MUST parse the literal octet count and use that as your guide to determine how many bytes the message is. That length value is not there for show, it's there because it is absolutely required in order to properly parse the response.

Hopefully I am just misunderstanding your code.