Hi Jeffrey,
nice to see you here!
Thank you really much for the code review. I agree with all points you mentioned. ImapX was originally written by another author, so some concepts are inherited, and by far not the best. With the latest version I started to change the approach how messages and other commands are executed and server responses are parsed. However, it takes time to completely go away from the string based processing, especially the line-by-line reading of server responses. First step here was adding of realtime processing of the server responses. Next is, as you have pointed out, base the message parsing on literal octet count and not dependent on any characters, such as ')'.
Currently I'm reading the docs of MimeKit to see how I can best use it in order to improve the performance of ImapX and also eliminate the existing bugs.
Best regards,
Pavel
nice to see you here!
Thank you really much for the code review. I agree with all points you mentioned. ImapX was originally written by another author, so some concepts are inherited, and by far not the best. With the latest version I started to change the approach how messages and other commands are executed and server responses are parsed. However, it takes time to completely go away from the string based processing, especially the line-by-line reading of server responses. First step here was adding of realtime processing of the server responses. Next is, as you have pointed out, base the message parsing on literal octet count and not dependent on any characters, such as ')'.
Currently I'm reading the docs of MimeKit to see how I can best use it in order to improve the performance of ImapX and also eliminate the existing bugs.
Best regards,
Pavel